[PATCH] D151020: [llvm-exegesis] Add ability to assign perf counters to specific PID

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 11:07:06 PDT 2023


mstorsjo added a comment.

In D151020#4442095 <https://reviews.llvm.org/D151020#4442095>, @aidengrossman wrote:

> Or, looks like Mac doesn't define that in their `unistd.h` header. I'll revert for now and figure out a better solution before relanding.

Thanks, much appreciated.

Yeah it seems less trivial than I would have wanted/expected to get this done, without adding e.g. a cmake level check for it. Alternatively, a strategy like "include all of <sys/types.h> and <unistd.h> and similar that are available, and then add a typedef if MSVC" might work too, but that's not exactly neat either.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151020/new/

https://reviews.llvm.org/D151020



More information about the llvm-commits mailing list