[PATCH] D153669: [RISCV] Add missing Read classe to some compressed instructions.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoC.td:554
 def C_JR : RVInst16CR<0b1000, 0b10, (outs), (ins GPRNoX0:$rs1),
-                      "c.jr", "$rs1">, Sched<[WriteJmpReg]> {
+                      "c.jr", "$rs1">, Sched<[WriteJmpReg, ReadJalr]> {
   let isBarrier = 1;
----------------
wangpc wrote:
> Comment not aim for this patch:
> Do we really need a SchedWrite `WriteJmpReg`? It's only used in C instructions and it won't influence scheduler actually.
> I think it can be removed and replaced by `WriteJalr`.
Agreed. I’ll post another patch for that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153669/new/

https://reviews.llvm.org/D153669