[llvm] bef4007 - [Attributor][NFC] Avoid string concat for non-tracing runs

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 21:20:01 PDT 2023


Hi Johannes,

Looks like one of your patches here
https://lab.llvm.org/buildbot/#/builders/74/builds/20083 breaks the bot
https://lab.llvm.org/buildbot/#/builders/74/builds/20084
Can you please fix or revert?

Thanks

On Fri, 23 Jun 2023 at 17:21, Johannes Doerfert via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

>
> Author: Johannes Doerfert
> Date: 2023-06-23T17:21:21-07:00
> New Revision: bef4007a421a35399dbdb5719299a6a9e6099bde
>
> URL:
> https://github.com/llvm/llvm-project/commit/bef4007a421a35399dbdb5719299a6a9e6099bde
> DIFF:
> https://github.com/llvm/llvm-project/commit/bef4007a421a35399dbdb5719299a6a9e6099bde.diff
>
> LOG: [Attributor][NFC] Avoid string concat for non-tracing runs
>
> Added:
>
>
> Modified:
>     llvm/include/llvm/Transforms/IPO/Attributor.h
>
> Removed:
>
>
>
>
> ################################################################################
> diff  --git a/llvm/include/llvm/Transforms/IPO/Attributor.h
> b/llvm/include/llvm/Transforms/IPO/Attributor.h
> index 72862b38f9fc1..babafdf8fa465 100644
> --- a/llvm/include/llvm/Transforms/IPO/Attributor.h
> +++ b/llvm/include/llvm/Transforms/IPO/Attributor.h
> @@ -1622,7 +1622,10 @@ struct Attributor {
>      }
>
>      {
> -      TimeTraceScope TimeScope(AA.getName() + "::initialize");
> +      TimeTraceScope TimeScope("initialize", [&]() {
> +        return AA.getName() +
> +               std::to_string(AA.getIRPosition().getPositionKind());
> +      });
>        ++InitializationChainLength;
>        AA.initialize(*this);
>        --InitializationChainLength;
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230623/80531b6d/attachment.html>


More information about the llvm-commits mailing list