<div dir="ltr">Hi <span style="color:rgb(51,51,51);font-family:"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:14px;background-color:rgb(249,249,249)">Johannes</span>, <div><br></div><div>Looks like one of your patches here <a href="https://lab.llvm.org/buildbot/#/builders/74/builds/20083">https://lab.llvm.org/buildbot/#/builders/74/builds/20083</a> breaks the bot <a href="https://lab.llvm.org/buildbot/#/builders/74/builds/20084">https://lab.llvm.org/buildbot/#/builders/74/builds/20084</a></div><div>Can you please fix or revert?</div><div><br></div><div>Thanks</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 23 Jun 2023 at 17:21, Johannes Doerfert via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Johannes Doerfert<br>
Date: 2023-06-23T17:21:21-07:00<br>
New Revision: bef4007a421a35399dbdb5719299a6a9e6099bde<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/bef4007a421a35399dbdb5719299a6a9e6099bde" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/bef4007a421a35399dbdb5719299a6a9e6099bde</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/bef4007a421a35399dbdb5719299a6a9e6099bde.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/bef4007a421a35399dbdb5719299a6a9e6099bde.diff</a><br>
<br>
LOG: [Attributor][NFC] Avoid string concat for non-tracing runs<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/include/llvm/Transforms/IPO/Attributor.h<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/include/llvm/Transforms/IPO/Attributor.h b/llvm/include/llvm/Transforms/IPO/Attributor.h<br>
index 72862b38f9fc1..babafdf8fa465 100644<br>
--- a/llvm/include/llvm/Transforms/IPO/Attributor.h<br>
+++ b/llvm/include/llvm/Transforms/IPO/Attributor.h<br>
@@ -1622,7 +1622,10 @@ struct Attributor {<br>
     }<br>
<br>
     {<br>
-      TimeTraceScope TimeScope(AA.getName() + "::initialize");<br>
+      TimeTraceScope TimeScope("initialize", [&]() {<br>
+        return AA.getName() +<br>
+               std::to_string(AA.getIRPosition().getPositionKind());<br>
+      });<br>
       ++InitializationChainLength;<br>
       AA.initialize(*this);<br>
       --InitializationChainLength;<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>