[PATCH] D153655: [LTO][GlobalDCE] Use pass parameter instead of module flag for LTO phase

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 14:51:43 PDT 2023


tejohnson marked 2 inline comments as done.
tejohnson added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:675
+Expected<bool> parseGlobalDCEPassOptions(StringRef Params) {
+  return parseSinglePassOption(Params, "in-lto-post-link", "InLTOPostLink");
+}
----------------
arsenm wrote:
> aeubanks wrote:
> > `GlobalDCE`
> Can you use a name descriptive of the behavior change, rather than the why/where?
Looks like it is supposed to be the pass name, fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153655/new/

https://reviews.llvm.org/D153655



More information about the llvm-commits mailing list