[PATCH] D153655: [LTO][GlobalDCE] Use pass parameter instead of module flag for LTO phase

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 14:45:38 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:675
+Expected<bool> parseGlobalDCEPassOptions(StringRef Params) {
+  return parseSinglePassOption(Params, "in-lto-post-link", "InLTOPostLink");
+}
----------------
aeubanks wrote:
> `GlobalDCE`
Can you use a name descriptive of the behavior change, rather than the why/where?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153655/new/

https://reviews.llvm.org/D153655



More information about the llvm-commits mailing list