[PATCH] D153638: [CodeGenPrepare][NFC] Update the dominator tree instead of rebuilding it

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 13:32:05 PDT 2023


nikic added a comment.

As a high level comment: If we always work on DTU, that would allow to only flush the DT updates when the DT is next accessed, rather than in each transform.



================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:586
   LI->releaseMemory();
-  LI->analyze(getDT(F));
+  LI->analyze(*DT);
 
----------------
Would it be hard to also preserve the DT though the handful of transforms above? If we did that, we could directly use the DT from the pass manager, and also preserve it afterwards as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153638/new/

https://reviews.llvm.org/D153638



More information about the llvm-commits mailing list