[PATCH] D153638: [CodeGenPrepare][NFC] Update the dominator tree instead of rebuilding it

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Have you tried to measure compile-time impact?



================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:6999
   StartBlock->getTerminator()->eraseFromParent();
+  DTU.applyUpdates({{DominatorTree::Delete, StartBlock, EndBlock}});
 
----------------
This might work, but it's going to be expensive; deleting the edge before adding the other edges will force the whole tree to be reconstructed, I think.

Can we use the SplitBlockAndInsertIfThen/SplitBlockAndInsertIfThenElse utilities here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153638/new/

https://reviews.llvm.org/D153638