[PATCH] D143762: [AMDGPU] Enable whole wave register copy

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 06:12:28 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SILowerPredicatedCopies.cpp:159
+        LLVM_DEBUG(dbgs() << "Updated " << MI << " to use COPY opcode");
+        MI.setDesc(TII->get(AMDGPU::COPY));
+        Changed |= true;
----------------
yassingh wrote:
> arsenm wrote:
> > Do these need to gain an implicit exec use?
> Do you mean we should add the implicit exec? In that case, SIFixVGPRCopies will take care?
This isn't something that can be taken care of later. SIFixVGPRCopies is a horribly broken hack, the less we depend on it the better


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143762/new/

https://reviews.llvm.org/D143762



More information about the llvm-commits mailing list