[PATCH] D153311: [Attributor] Unify AAMemoryLocation and AAMemoryBehavior

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 10:59:17 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:4539
+  unsigned NonFixMemoryEffects;
+  SmallVector<char> ArgMapping;
+  SmallVector<AA::MemoryEffects, 8> AssumedEffects, KnownEffects;
----------------
nikic wrote:
> Will overflow with many args?
If this is really a hard argument limit, it's way too small. llvm-reduce likes to move instructions to arguments, so I'm sure I'll run into something where this overflows in no time


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153311/new/

https://reviews.llvm.org/D153311



More information about the llvm-commits mailing list