[PATCH] D153311: [Attributor] Unify AAMemoryLocation and AAMemoryBehavior

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:4539
+  unsigned NonFixMemoryEffects;
+  SmallVector<char> ArgMapping;
+  SmallVector<AA::MemoryEffects, 8> AssumedEffects, KnownEffects;
----------------
Will overflow with many args?


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:8332
+    case Instruction::Load:
+      return AA::MemoryEffects::readOnly();
+
----------------
Does this handle volatile loads correctly? Those can also write (and access inaccessible memory).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153311/new/

https://reviews.llvm.org/D153311