[PATCH] D153337: [MachineLICM][WinEH] Don't hoist register reloads out of funclets
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 22 09:05:00 PDT 2023
arsenm added a comment.
Needs tests
================
Comment at: llvm/lib/CodeGen/MachineLICM.cpp:540-543
for (const auto &LI : BB->liveins()) {
for (MCRegAliasIterator AI(LI.PhysReg, TRI, true); AI.isValid(); ++AI)
PhysRegDefs.set(*AI);
}
----------------
We're moving towards reverse block liveness. Modern liveness queries start at the end of the block and walk backwards, but this is walking forward looking for defs. Can this pass switch to using LiveRegUnits and stepBackwards?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153337/new/
https://reviews.llvm.org/D153337
More information about the llvm-commits
mailing list