[PATCH] D153337: [MachineLICM][WinEH] Don't hoist register reloads out of funclets

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 21 11:26:04 PDT 2023


efriedma added reviewers: arsenm, MatzeB.
efriedma added a comment.
Herald added a subscriber: wdng.

The concept here seems right; we should treat funclet entry as if it clobbers all registers.

I'm not sure about the implementation here; we should have some common utility that encompasses this.  Making MachineLICM compute its own version of which registers are live seems liable to lead to bugs.  I guess getBeginClobberMask() is supposed to encompass what this is checking for?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153337/new/

https://reviews.llvm.org/D153337



More information about the llvm-commits mailing list