[PATCH] D153517: [AMDGPU] ISel for amdgpu_cs_chain[_preserve] functions

Thu Jun 22 03:59:37 PDT 2023

rovka added inline comments.

================
Comment at: llvm/test/CodeGen/AMDGPU/amdgpu-cs-chain-cc.ll:10
+; RUN: llc -global-isel=0 -march=amdgcn -mcpu=gfx1030 -mattr=-wavefrontsize32,+wavefrontsize64 -stop-after=finalize-isel -verify-machineinstrs < %s | FileCheck -check-prefix=DAGISEL-GFX10 %s
+
+; Test formal argument lowering as well as calls to amdgpu_gfx functions.
----------------
arsenm wrote:
> Add gfx6 or 7 run line from before s105 existed?
I don't think we plan to use this on targets older than gfx10, and adding more run lines here would make it even harder to follow changes to the checks (which are honestly already a bit of an eyesore). Should I just use a lower register number for now? How does s52 sound? 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153517/new/

https://reviews.llvm.org/D153517