[PATCH] D153517: [AMDGPU] ISel for amdgpu_cs_chain[_preserve] functions

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 03:32:45 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/amdgpu-cs-chain-cc.ll:205
+  ; DAGISEL-GFX10-NEXT:   S_ENDPGM 0
+  call amdgpu_gfx void @use(ptr %a, ptr %b)
+  ret void
----------------
Don't think these tests cover different address space pointers


================
Comment at: llvm/test/CodeGen/AMDGPU/amdgpu-cs-chain-cc.ll:512
+  ; DAGISEL-GFX10-NEXT:   S_ENDPGM 0
+  call amdgpu_gfx void @use(half %a, half %b)
+  ret void
----------------
Test bfloat too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153517/new/

https://reviews.llvm.org/D153517



More information about the llvm-commits mailing list