[PATCH] D152869: [nfc] Factoring out utility that can be used for other object-level tools

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Thanks @JestrTulip, this gets a soft LGTM from me, but as noted, the other patch needs accepting before this lands.



================
Comment at: llvm/include/llvm/Object/ObjectFile.h:408
+  SectionFilterIterator(SectionFilterPredicate Pred,
+                        llvm::object::section_iterator const &Begin,
+                        llvm::object::section_iterator const &End)
----------------
Since you're moving this code into the `llvm::object` namespace, I believe all these `llvm::object::` prefixes can disappear. Please do that.

It's also a good chance to tidy up some of the style issues. In particular, LLVM code prefers "west const" (i.e. the const before the type name).

These points apply thoughour the moved code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152869/new/

https://reviews.llvm.org/D152869