[PATCH] D152869: [nfc] Factoring out utility that can be used for other object-level tools
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 20 21:26:25 PDT 2023
MaskRay added a comment.
In D152869#4436188 <https://reviews.llvm.org/D152869#4436188>, @JestrTulip wrote:
> In D152869#4419733 <https://reviews.llvm.org/D152869#4419733>, @MaskRay wrote:
>
>> Can you state the motivation and link to the follow-up patch?
>
> Added the rfc and intro patch, is there anything else I should do to for this to get accepted?
Yes. I feel the same with @jhenderson .
> it shouldn't land unless the RFC is accepted and the corresponding patch is still using it once the final version is accepted.
I am happy to be more lenient to "once the final version is accepted". I am happy once "the patch will clearly land (approved or will eventually be) and the final version or the agreed direction will use the shared code when it lands."
So, sorry, I don't think the patch can land now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152869/new/
https://reviews.llvm.org/D152869
More information about the llvm-commits
mailing list