[PATCH] D153096: [MC] Fold A-B when A's fragment precedes B's fragment

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/MC/ARM/directive-if-subtraction.s:23
+// OBJ-NOT:[[@LINE-1]]:5: error: expected absolute expression
+// ASM:[[@LINE-2]]:5: error: expected absolute expression
+// DISASM: orr	r1, r1, #2
----------------
nickdesaulniers wrote:
> I thought the whole point of this patch is to allow `9997b - . == 0` to fold? Then why is this testing for that to emit an error?
This test complements the previous test that we still have `// ASM:[[@LINE-2]]:5: error: expected absolute expression`.

This is related to a larger issue that for now we use `MCAsmStreamer::getAssemblerPtr` that returns null (related to D45164). I have found that improving this would be challenging.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153096/new/

https://reviews.llvm.org/D153096