[PATCH] D152328: InstrProf - don't emit 64 bit atomic operations on 32 bit platforms

[Ellis Hoag via Phabricator via llvm-commits]

ellis added a comment.

In D152328#4436240 <https://reviews.llvm.org/D152328#4436240>, @SeanMollet wrote:

> In D152328#4436231 <https://reviews.llvm.org/D152328#4436231>, @ellis wrote:
>
>> In D152328#4436143 <https://reviews.llvm.org/D152328#4436143>, @davidxl wrote:
>>
>>> There is an example in InstrProfiling.cpp about missing debug information warning.
>>>
>>> For the emulation feature, it is ok to delay it -- but please do a TODO as a comment.
>>
>> Yeah I kind of regret adding this warning as it is. It is definitely pretty spammy and the only way to suppress it is to suppress all backend warnings.
>
> I was thinking a static flag that gets set on the first warning and then skip subsequent ones. I could wrap that other warning as well. Just didn't want to go randomly adding static variables since I have no idea about the policies surrounding things like that.

Even with a static flag, that doesn't stop the warning from showing up from each clang invocation if you aren't using LTO.

By the way, why not simply use `-fprofile-update=single` (which I think will set `Options.Atomic = false`) for your use case? Now that I look closely, all the atomic flags seem to be false by default. Where are you seeing atomic instructions emitted for you?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152328/new/

https://reviews.llvm.org/D152328