[PATCH] D152328: InstrProf - don't emit 64 bit atomic operations on 32 bit platforms

Sean Mollet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 16:09:02 PDT 2023

SeanMollet added a comment.

In D152328#4436231 <https://reviews.llvm.org/D152328#4436231>, @ellis wrote:

> In D152328#4436143 <https://reviews.llvm.org/D152328#4436143>, @davidxl wrote:
>> There is an example in InstrProfiling.cpp about missing debug information warning.
>> For the emulation feature, it is ok to delay it -- but please do a TODO as a comment.
> Yeah I kind of regret adding this warning as it is. It is definitely pretty spammy and the only way to suppress it is to suppress all backend warnings.

I was thinking a static flag that gets set on the first warning and then skip subsequent ones. I could wrap that other warning as well. Just didn't want to go randomly adding static variables since I have no idea about the policies surrounding things like that.



More information about the llvm-commits mailing list