[PATCH] D152328: InstrProf - don't emit 64 bit atomic operations on 32 bit platforms
David Li via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 20 12:36:56 PDT 2023
davidxl added a comment.
For target without hw instruction for fetch add, intrinsic like __sync_fetch_and_add() can be used instead -- it will be slow but workable. Why disabling it?
================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:456
bool InstrProfiling::isCounterPromotionEnabled() const {
+ if (!targetSupportsAtomic())
----------------
why disabling counter promotion? It is a different from atomic counter update.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152328/new/
https://reviews.llvm.org/D152328
More information about the llvm-commits
mailing list