[llvm] 0ce2ce2 - Revert "Fix mlir windows buildbot after ec146cb7c0b4"

Anna Thomas via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 12:29:57 PDT 2023


Author: Anna Thomas
Date: 2023-06-20T15:29:53-04:00
New Revision: 0ce2ce2a47c7f71dbbcae3c8bb5604395926c85c

URL: https://github.com/llvm/llvm-project/commit/0ce2ce2a47c7f71dbbcae3c8bb5604395926c85c
DIFF: https://github.com/llvm/llvm-project/commit/0ce2ce2a47c7f71dbbcae3c8bb5604395926c85c.diff

LOG: Revert "Fix mlir windows buildbot after ec146cb7c0b4"

This reverts commit 46c2e1fdb3065542bed96ba944ae4a58465d2b5e.

The fix was already landed in 51e917d4af.

Added: 
    

Modified: 
    llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
index ee2ffd3f69cb5..3416e953e099b 100644
--- a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
+++ b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
@@ -12767,9 +12767,6 @@ class HorizontalReduction {
         return Builder.CreateSelect(Cmp, LHS, RHS, Name);
       }
       return Builder.CreateBinaryIntrinsic(Intrinsic::umin, LHS, RHS);
-    // TODO: Add support for these recurrences.  
-    case RecurKind::FMaximum:
-    case RecurKind::FMinimum:
     default:
       llvm_unreachable("Unknown reduction operation.");
     }
@@ -13814,9 +13811,6 @@ class HorizontalReduction {
       });
       break;
     }
-    // TODO: Add support for these recurrences.  
-    case RecurKind::FMaximum:
-    case RecurKind::FMinimum:
     default:
       llvm_unreachable("Expected arithmetic or min/max reduction operation");
     }
@@ -13886,9 +13880,6 @@ class HorizontalReduction {
     case RecurKind::FMulAdd:
     case RecurKind::SelectICmp:
     case RecurKind::SelectFCmp:
-    // TODO: Add support for these recurrences.  
-    case RecurKind::FMaximum:
-    case RecurKind::FMinimum:
     case RecurKind::None:
       llvm_unreachable("Unexpected reduction kind for repeated scalar.");
     }
@@ -13978,9 +13969,6 @@ class HorizontalReduction {
     case RecurKind::FMulAdd:
     case RecurKind::SelectICmp:
     case RecurKind::SelectFCmp:
-    // TODO: Add support for these recurrences.  
-    case RecurKind::FMaximum:
-    case RecurKind::FMinimum:
     case RecurKind::None:
       llvm_unreachable("Unexpected reduction kind for reused scalars.");
     }


        


More information about the llvm-commits mailing list