[PATCH] D150856: [lit] Add %{for-each-file} substitution

Tue Jun 20 10:42:07 PDT 2023

Endill added a comment.

In D150856#4435479 <https://reviews.llvm.org/D150856#4435479>, @jdenny wrote:

> In D150856#4434511 <https://reviews.llvm.org/D150856#4434511>, @aaron.ballman wrote:
>
>> IMO, yes.
>
> The vote stands at 2 to 1 in favor of `%{for-each-file}` as opposed to using the existing DEFINE/REDEFINE functionality.  I don't have any additional information to present, so we should let others weigh in on this point.
>
> If some form of `%{for-each-file}` is the chosen path forward, I hope @jhenderson's suggestion for a different syntax will be pursued.  Replicating the enclosing RUN line is a surprising side effect for a //substitution//.

If we can agree that lit should provide first-class iteration facilities, I have no troubles reimplementing this patch according to my earlier suggestion <https://reviews.llvm.org/D150856#4424116>, which is in line with @jhenderson's suggestion as I understand it. If we find generic (non-file) iteration facilities useful for DR testing, I can contribute them as well later.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150856/new/

https://reviews.llvm.org/D150856