[PATCH] D150856: [lit] Add %{for-each-file} substitution
Joel E. Denny via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 20 10:19:38 PDT 2023
jdenny added a reviewer: yln.
jdenny added a comment.
In D150856#4434511 <https://reviews.llvm.org/D150856#4434511>, @aaron.ballman wrote:
> IMO, yes.
The vote stands at 2 to 1 in favor of `%{for-each-file}` as opposed to using the existing DEFINE/REDEFINE functionality. I don't have any additional information to present, so we should let others weigh in on this point.
If some form of `%{for-each-file}` is the chosen path forward, I hope @jhenderson's suggestion for a different syntax will be pursued. Replicating the enclosing RUN line is a surprising side effect for a //substitution//.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150856/new/
https://reviews.llvm.org/D150856
More information about the llvm-commits
mailing list