[PATCH] D152993: [VP][RISCV] Add vp.is.fpclass and RISC-V support

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7930
+    SDNodeFlags SDFlags;
+    SDFlags.setNoFPExcept(
+        !MF.getFunction().getAttributes().hasFnAttr(llvm::Attribute::StrictFP));
----------------
craig.topper wrote:
> arsenm wrote:
> > This should be unnecessary, by definition this is not a floating point operation and cannot raise FP exceptions 
> Doesn't this code also exist for Intrinsic::is_fpclass?
If it does it shouldn’t . Can either drop it or make it an unconditional true 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152993/new/

https://reviews.llvm.org/D152993