[PATCH] D152993: [VP][RISCV] Add vp.is.fpclass and RISC-V support

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 12:48:17 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7930
+    SDNodeFlags SDFlags;
+    SDFlags.setNoFPExcept(
+        !MF.getFunction().getAttributes().hasFnAttr(llvm::Attribute::StrictFP));
----------------
arsenm wrote:
> This should be unnecessary, by definition this is not a floating point operation and cannot raise FP exceptions 
Doesn't this code also exist for Intrinsic::is_fpclass?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152993/new/

https://reviews.llvm.org/D152993



More information about the llvm-commits mailing list