[PATCH] D153277: [BOLT][RISCV] Recognize mapping symbols

[Amir Ayupov via Phabricator via llvm-commits]

Amir accepted this revision.
Amir added a comment.
This revision is now accepted and ready to land.

In D153277#4433191 <https://reviews.llvm.org/D153277#4433191>, @jobnoorman wrote:

> In D153277#4433169 <https://reviews.llvm.org/D153277#4433169>, @Amir wrote:
>
>> The test is failing in pre-merge checks – can you please verify why?
>
> Ugh, this is caused by the pre-merge checks using the system's clang (`-DBOLT_CLANG_EXE=/usr/bin/clang` is passed to cmake). This patch depends on a change in the RISC-V MC layer (D153260 <https://reviews.llvm.org/D153260>) so won't work with an old clang.
>
> I'm not quite sure how to solve this, other than updating the pre-merge checks to build clang itself. Would this be an option?
>
> Note that this isn't the first time I had to make MC changes for BOLT RISC-V support and I assume it won't be the last so I'm a bit afraid this issue might come up again in the future.

Thanks for checking. Yes, it's an inconvenience that we need to keep in mind. It's a choice not to overburden the pre-merge builder with clang and lld builds that are needed for tests only.

LG in general, but let's wait until the dependencies are landed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153277/new/

https://reviews.llvm.org/D153277