[PATCH] D153277: [BOLT][RISCV] Recognize mapping symbols

Job Noorman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 09:42:46 PDT 2023


jobnoorman added a comment.

In D153277#4433169 <https://reviews.llvm.org/D153277#4433169>, @Amir wrote:

> The test is failing in pre-merge checks – can you please verify why?

Ugh, this is caused by the pre-merge checks using the system's clang (`-DBOLT_CLANG_EXE=/usr/bin/clang` is passed to cmake). This patch depends on a change in the RISC-V MC layer (D153260 <https://reviews.llvm.org/D153260>) so won't work with an old clang.

I'm not quite sure how to solve this, other than updating the pre-merge checks to build clang itself. Would this be an option?

Note that this isn't the first time I had to make MC changes for BOLT RISC-V support and I assume it won't be the last so I'm a bit afraid this issue might come up again in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153277/new/

https://reviews.llvm.org/D153277



More information about the llvm-commits mailing list