[PATCH] D150384: [CodeGenPrepare] Fix for using outdated/corrupt LoopInfo

[Momchil Velikov via Phabricator via llvm-commits]

chill added a comment.

In D150384#4432424 <https://reviews.llvm.org/D150384#4432424>, @nikic wrote:

> Doesn't this change essentially break the current model where DT is supposed to only be calculated lazily, if it is needed? Now we'll end up always calculating it on each iteration.
>
> I think if you do this, you also need to start keeping DT up to date everywhere, instead of using the current crude invalidation approach.



In D150384#4432424 <https://reviews.llvm.org/D150384#4432424>, @nikic wrote:

> Doesn't this change essentially break the current model where DT is supposed to only be calculated lazily, if it is needed? Now we'll end up always calculating it on each iteration.
>
> I think if you do this, you also need to start keeping DT up to date everywhere, instead of using the current crude invalidation approach.

Now that we don't have (?) correctness/corruption issues, I'll see what I can do about updating the DT. (From a quick glance it does not seem like a terribly huge amount of work).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150384/new/

https://reviews.llvm.org/D150384