[PATCH] D150384: [CodeGenPrepare] Fix for using outdated/corrupt LoopInfo

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 05:06:34 PDT 2023


nikic added a comment.

Doesn't this change essentially break the current model where DT is supposed to only be calculated lazily, if it is needed? Now we'll end up always calculating it on each iteration.

I think if you do this, you also need to start keeping DT up to date everywhere, instead of using the current crude invalidation approach.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150384/new/

https://reviews.llvm.org/D150384



More information about the llvm-commits mailing list