[PATCH] D152963: [RISCV] Don't assume tail undefined if there's no policy op
Luke Lau via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 19 07:07:16 PDT 2023
luke added a comment.
In D152963#4426047 <https://reviews.llvm.org/D152963#4426047>, @reames wrote:
> In D152963#4424968 <https://reviews.llvm.org/D152963#4424968>, @reames wrote:
>
>> Can I ask you to hold this patch for a day or so? I've got an idea on correctly inferring tail undefined here that I want to try out. If it works, this becomes much closer to NFC.
>
> The more complicated idea turned out not to be needed, and instead I posted the mini series ending in https://reviews.llvm.org/D153070.
>
> I think if you rebase on that, some of your diffs should disappear. I am curious as to the case which requires the _TU pseudo for VPatBinaryM. I didn't run into that with my change, and I suspect your refactor here is creating more TU nodes.
Rebasing removed the diffs in rvv-peephole-vmerge-vops.ll, allone-masked-to-unmasked.ll and fixed-vectors-peephole-vmerge-vops.ll, but the other diffs remain. Will update this revision shortly
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152963/new/
https://reviews.llvm.org/D152963
More information about the llvm-commits
mailing list