[PATCH] D150856: [lit] Add %{for-each-file} substitution

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D150856#4428905 <https://reviews.llvm.org/D150856#4428905>, @Endill wrote:

>> https://gist.github.com/jdenny-ornl/82aae9c3706c88fedebc8c44ac2a6694
>
> So we're looking at 20% more noise in a large test suite. I'm not happy with that either.

When comparing the character counts for the solution using `%{for-each-file}` and the solution above using DEFINE/REDEFINE, I see a 9% increase for the latter.

But what does that number really mean anyway?  It boils down to the following.  When formatting the DR tests as lit tests, the `%{for-each-file}` solution requires adding the following header to each DR test:

  //--- dr500: dup 372

where the DEFINE/REDEFINE solution requires adding the following header instead:

  //--- dr500: dup 372
  // REDEFINE: %{file} = dr500.cpp
  // RUN: %{run}

As far as I can tell, neither version introduces any significant maintenance burden to the DR test.  The former is just more concise..  But does that difference justify maintaining `%{for-each-file}` in lit?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150856/new/

https://reviews.llvm.org/D150856