[PATCH] D153223: [RL78 patch 1] Add RL78 ELF defintions

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/ELFRelocs/RL78.def:54
+ELF_RELOC(R_RL78_OPABSlowW,   0xa9)
\ No newline at end of file

----------------
No newline at end of file. Please add one


================
Comment at: llvm/test/tools/llvm-readobj/ELF/reloc-types-rl78.test:1
+## Test that llvm-readobj shows proper relocation type
+## names and values for the RL78 target.
----------------
Seems to wrap too early.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/rl78-header-flags.test:1
+## Check that we are able to dump EF_RL78_* flags correctly
+
----------------
Complete sentences in comments should end with a period. Fix this throughout.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153223/new/

https://reviews.llvm.org/D153223