[PATCH] D146776: [llvm] Preliminary fat-lto-objects support

Sat Jun 17 00:55:03 PDT 2023

nikic added inline comments.

================
Comment at: llvm/docs/FatLTOSupport.rst:49
+Internally, the ``.llvm.lto`` section is created by running the
+``EmbedBitcodePass`` at the start of the `PerModuleDefaultPipeline`. This pass
+is responsible for cloning and optimizing the module with the appropriate LTO
----------------

================
Comment at: llvm/docs/FatLTOSupport.rst:61
+
+Currently, using LTO with LLVM fat lto objects is supported by LLD and the by
+GNU linkers via the LLVMGold plugin. This may change in the future, but
----------------

================
Comment at: llvm/docs/FatLTOSupport.rst:60
+after the section is created, we then run the normal compilation pipeline on an
+unmodified copy of the module.
+
----------------
paulkirth wrote:
> paulkirth wrote:
> > nikic wrote:
> > > I feel like this information has been repeated (with minor variations) three times: In the bullet points above, the paragraph following it, and then here...
> > Yeah, it's definitely a bit redundant. I'll go through this one more time and try to streamline the text.
> I feel like the current version reads a bit better. WDYT?
Looks good!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146776/new/

https://reviews.llvm.org/D146776