[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 17 00:34:55 PDT 2023


nikic added a comment.

Could you please rebase the patch to current main? I wasn't able to apply it.

The behavior you describe sounds reasonable to me.



================
Comment at: llvm/utils/UpdateTestChecks/common.py:1286
+      if value == default_value:
+        continue
     if action.dest == 'filters':
----------------
We should also not print the `all` argument for `--check-globals` argument for `version < 3`, otherwise that will introduce a spurious change in all such tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148216/new/

https://reviews.llvm.org/D148216



More information about the llvm-commits mailing list