[PATCH] D153189: [MC] Make .pseudo_probe GC-able

[Hongtao Yu via Phabricator via llvm-commits]

hoy added a comment.

Thanks for working on this! It looks better than using function name for deduplication and gc.



================
Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:1179
+
+  return Ctx->getELFSection(PseudoProbeSection->getName(), ELF::SHT_PROGBITS,
+                            Flags, 0, GroupName, true, ElfSec.getUniqueID(),
----------------
I think the type should inherit the type of `PseudoProbeSection`.


================
Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:1180
+  return Ctx->getELFSection(PseudoProbeSection->getName(), ELF::SHT_PROGBITS,
+                            Flags, 0, GroupName, true, ElfSec.getUniqueID(),
+                            cast<MCSymbolELF>(TextSec.getBeginSymbol()));
----------------
Should the pseudo probe section be a comdat only if the text section is a comdat? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153189/new/

https://reviews.llvm.org/D153189