[PATCH] D119049: [LLD] Allow usage of LLD as a library

[Fangrui Song via Phabricator via llvm-commits]

MaskRay reopened this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

In D119049#4429615 <https://reviews.llvm.org/D119049#4429615>, @aganea wrote:

> In D119049#4429553 <https://reviews.llvm.org/D119049#4429553>, @MaskRay wrote:
>
>> In D119049#4429521 <https://reviews.llvm.org/D119049#4429521>, @aganea wrote:
>>
>>> With binary files.
>>
>> I see that
>>
>>   config.environment["LLD_SRC_DIR"] = config.lld_src_dir
>>
>> sets the correct path, but `ninja check-lld-unit` still fails due to `thisPath.append(getenv("LLD_SRC_DIR"));` getting an empty string...
>
> Can you post your entire `cmake` command?

A bit complex and unrelated to the issue...

  https://github.com/MaskRay/Config/wiki/LLVM#configuration
  configure-llvm preset

I confirm that `/tmp/Debug/tools/lld/unittests/AsLibELF/LLDAsLibELFTests` does receive `LLD_SRC_DIR` and `kernel1.o` can be found.
The problem is that `curl -L 'https://reviews.llvm.org/D119049?download=1'` doesn't contain `kernel1.o` or `kernel2.o`, so others cannot verify.

You may land the patch and disable the unittest if needed...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119049/new/

https://reviews.llvm.org/D119049