[PATCH] D153096: [MC] Fold A-B when A's fragment precedes B's fragment

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 16 17:36:28 PDT 2023


MaskRay added a comment.

In D153096#4427202 <https://reviews.llvm.org/D153096#4427202>, @barannikov88 wrote:

> The logic below is quite difficult to follow. Displacement being negated twice on some code paths is very confusing.
> Can it be simplified somehow? Possibly by more intrusive changes?
> Otherwise LGTM.

Thanks for sharing thoughts. I have locally implemented another approach that detects which of FA/FB occurs first, but the code turns out to be more complex, and more complex when the RISC-V linker relaxation code (D153097 <https://reviews.llvm.org/D153097>) is added...
The current code is the best I can think of.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153096/new/

https://reviews.llvm.org/D153096



More information about the llvm-commits mailing list