[PATCH] D146853: [Pseudo Probe] Placing .pseudoprobe section in the same comdat group with .text

Fri Jun 16 13:15:24 PDT 2023

MaskRay added a comment.

In D146853#4428709 <https://reviews.llvm.org/D146853#4428709>, @hoy wrote:

> In D146853#4428673 <https://reviews.llvm.org/D146853#4428673>, @MaskRay wrote:
>
>> Thank you for mentioning lld/ELF, otherwise I may not notice this patch:) The part is not so related to the main functionality and I usually have a strong opinion on lld/test/ELF testing...
>
> A test on lld side sounds good. I'll add it.
>
>> Actually, for LLVM metadata sections, I think the convention is not to have a suffix like `.text.foo`. You may want to use `.pseudo_probe` without the suffix (`MCSectionELF::UniqueID`).
>
> D152546 <https://reviews.llvm.org/D152546> is one implementation that treats `.pseudo_probe` as an independent section of `.text`, but after iterations we think they should be combined when it comes to deduplication and gc-sections, so I'm falling back to this patch.

My idea is that we should not have `.pseudo_probe.xxx` (waste `.strtab` size). Just have a number of `.pseudo_probe`. This scheme matches many other metadata sections from all sorts of instrumentations.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146853/new/

https://reviews.llvm.org/D146853