[PATCH] D152944: [BOLT] Mark sections read-only based on PT_GNU_RELRO segment

[Amir Ayupov via Phabricator via llvm-commits]

Amir added a comment.

In D152944#4428996 <https://reviews.llvm.org/D152944#4428996>, @maksfb wrote:

> I think we need a new type for RELRO sections. We rely on the contents of regular read-only sections to match that in the file. While for RELRO, the contents will depend on the presence of runtime relocations against any region and the type of relocations.

Makes sense.

>> Update gotpcrelx.s test as we start recognizing jmp *foo at GOTPCREL(%rip) as fixed indirect jump and convert it to a tail call with X86::JMP32m opcode.
>
> If we recognize it as a fixed jump, why does the test case still have an indirect jump?

We keep mem-indirect jumps indirect: https://github.com/llvm/llvm-project/blob/7a709689bc1755a569864a97d93b96d22f988eb4/bolt/lib/Target/X86/X86MCPlusBuilder.cpp#L1570


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152944/new/

https://reviews.llvm.org/D152944