[PATCH] D146776: [llvm] Preliminary fat-lto-objects support

Fri Jun 16 12:47:55 PDT 2023

paulkirth added a comment.

In D146776#4429120 <https://reviews.llvm.org/D146776#4429120>, @MaskRay wrote:

> Apologies for not commenting soon. I'll take a close look shortly.

TY!

================
Comment at: llvm/docs/FatLTOSupport.rst:60
+after the section is created, we then run the normal compilation pipeline on an
+unmodified copy of the module.
+
----------------
nikic wrote:
> I feel like this information has been repeated (with minor variations) three times: In the bullet points above, the paragraph following it, and then here...
Yeah, it's definitely a bit redundant. I'll go through this one more time and try to streamline the text.

================
Comment at: llvm/docs/FatLTOSupport.rst:73
+linker via the LLVMGold plugin. This may change in the future, but extending
+support to other linkers isn't planned for now.
+
----------------
nikic wrote:
> Despite the name, the gold plugin is also supported by the bfd linker, so you actually support all common linkers (on ELF based systems).
Ah, right. I completely forgot bfd could use the plugin.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146776/new/

https://reviews.llvm.org/D146776