[PATCH] D146776: [llvm] Preliminary fat-lto-objects support

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/docs/FatLTOSupport.rst:37
+The ``FatLTODefaultPipeline`` does this by running the pre-link (Thin)LTO
+pipeline on a copy of the unmodifeid module, saving the optimized copy in a new
+``.llvm.lto`` section, and then running the ``PerModuleDefaultPipeline`` on
----------------
unmodified


================
Comment at: llvm/docs/FatLTOSupport.rst:60
+after the section is created, we then run the normal compilation pipeline on an
+unmodified copy of the module.
+
----------------
I feel like this information has been repeated (with minor variations) three times: In the bullet points above, the paragraph following it, and then here...


================
Comment at: llvm/docs/FatLTOSupport.rst:73
+linker via the LLVMGold plugin. This may change in the future, but extending
+support to other linkers isn't planned for now.
+
----------------
Despite the name, the gold plugin is also supported by the bfd linker, so you actually support all common linkers (on ELF based systems).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146776/new/

https://reviews.llvm.org/D146776