[PATCH] D151254: InstSimplify: Require instruction be parented

[Alan Zhao via Phabricator via llvm-commits]

ayzhao added a comment.

Copy/pasting my comment from https://reviews.llvm.org/rG1536e299e63d7788f38117b0212ca50eb76d7a3b#1217141 (I didn't see this code review because this commit didn't have the "Differential Revision" line)

Chrome is seeing a regression where the build size increased for Android and Fuchsia (https://crbug.com/1454531) - see the attached files.

Repro steps:

  $ opt -passes=inline before-inline.S

The diff before and after this patch contains the following extra instructions:

  while.cond.i.i.preheader.i.i:                     ; preds = %_ZNSt4__Cr6vectorIPN4base5ValueENS_9allocatorIS3_EEE4backEv.exit254.i, %_ZNSt4__Cr6vectorIPN4base5ValueENS_9allocatorIS3_EEE4backEv.exit242.i, %_ZNSt4__Cr6vectorIPN4base5ValueENS_9allocatorIS3_EEE4backEv.exit.i
    %cmp.not.i.i.i.i.i.i.i = icmp eq ptr %add.ptr.i.i, null
    br i1 %cmp.not.i.i.i.i.i.i.i, label %cond.false.i.i.i.i.i.i.i, label %_ZNSt4__Cr6vectorIPN4base5ValueENS_9allocatorIS3_EEE8pop_backEv.exit.i, !prof !4, !llvm.loop !5
  
  cond.false.i.i.i.i.i.i.i:                         ; preds = %while.cond.i.i.preheader.i.i
    call void (ptr, ...) @_ZNSt4__Cr22__libcpp_verbose_abortEPKcz(ptr noundef nonnull @.str.10, ptr noundef nonnull @.str.11, i32 noundef 65, ptr noundef nonnull @.str.17, ptr noundef nonnull @.str.18) #29
    unreachable

F27940576: before-inline.S <https://reviews.llvm.org/F27940576>

F27940575: after-inline-old.S <https://reviews.llvm.org/F27940575>

F27940574: after-inline-new.S <https://reviews.llvm.org/F27940574>


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151254/new/

https://reviews.llvm.org/D151254