[PATCH] D153066: [AppleTables] Implement iterator over all entries in table

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h:248
 
+  struct EntryWithName final : Entry {
+    EntryWithName(const AppleAcceleratorTable &Table)
----------------
Ah, sorry, I probably wouldn't complicate this by deriving, needing a virtual dtor, etc.

Maybe composition? EntryWithName could be closer to the std::pair (but, yeah, it needs to be a bit smarter) than this - contains an Entry, the offset and a function to get the name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153066/new/

https://reviews.llvm.org/D153066