[PATCH] D152550: [Constant Hoisting]: Hoist Constant GEP Expressions.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.
Herald added a subscriber: wangpc.

I don't recall the details of this, but I think we just didn't spend the time to do the work necessary to enable by default.

For a lot of these regression tests, it isn't obvious why you're passing `consthoist-gep=false`.



================
Comment at: llvm/test/CodeGen/RISCV/hoist-global-addr-base.ll:38
 ; CHECK-NEXT:  # %bb.1: # %if.then
+; CHECK-NEXT:    addi a0, a0, 160
 ; CHECK-NEXT:    li a1, 10
----------------
Regression


================
Comment at: llvm/test/CodeGen/RISCV/hoist-global-addr-base.ll:290
+; CHECK-NEXT:    addi a0, a0, %lo(s)
+; CHECK-NEXT:    lw a1, 164(a0)
 ; CHECK-NEXT:    blez a1, .LBB17_2
----------------
Regression.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152550/new/

https://reviews.llvm.org/D152550