[PATCH] D153155: [RISCV] Remove legacy TA/TU pseudo distiction for VID

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 16 10:41:17 PDT 2023


reames created this revision.
reames added reviewers: luke, craig.topper, asb, frasercrmck.
Herald added subscribers: jobnoorman, VincentWu, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, bollu, simoncook, johnrusso, rbar, hiraditya, arichardson, mcrosier.
Herald added a project: All.
reames requested review of this revision.
Herald added subscribers: wangpc, eopXD, MaskRay.
Herald added a project: LLVM.

This is a follow on to D152740 <https://reviews.llvm.org/D152740>.  The focus of this patch is on actually removing the old TA (unsuffixed) version.  I realized we already had plumbing for combined TA/TU pseudos - used by some of the ternary instructions.  As such, we can go ahead and fully remove the old TA, and rename the _TU variant to be unsuffixed.  (The rename must happen in this patch for the table structure to work out as expected.)

The scheduling difference comes from an omission in D152740 <https://reviews.llvm.org/D152740>.  If we selected a _MASK variant - either from manual ISEL or instrincs - we were going through doPeepholeMaskedRVV and still getting the TA variant.  The use of the IsCombined flag in the MaskedPseudo table causes us to use the TU (now unsuffixed) variant instead.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D153155

Files:
  llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td
  llvm/test/CodeGen/RISCV/rvv/fixed-vectors-int-buildvec.ll
  llvm/test/CodeGen/RISCV/rvv/fixed-vectors-int.ll
  llvm/test/CodeGen/RISCV/rvv/fixed-vectors-interleaved-access.ll
  llvm/test/CodeGen/RISCV/rvv/fixed-vectors-reduction-int-vp.ll
  llvm/test/CodeGen/RISCV/rvv/fixed-vectors-store.ll
  llvm/test/CodeGen/RISCV/rvv/named-vector-shuffle-reverse.ll
  llvm/test/CodeGen/RISCV/rvv/stepvector.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153155.532217.patch
Type: text/x-patch
Size: 66157 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230616/e06e1571/attachment-0001.bin>


More information about the llvm-commits mailing list