[PATCH] D150856: [lit] Add %{for-each-file} substitution

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 16 10:07:46 PDT 2023


jdenny added a comment.

In D150856#4428690 <https://reviews.llvm.org/D150856#4428690>, @aaron.ballman wrote:

> My primary concern is how easy it will be for someone to extend these tests.

Under my proposal, you just extend a `%{run}` definition.  You don't have to modify the individual split-out files again.  Moreover, if you're using the same commands in many lit test files, you could define `%{run}` in a lit config file.

> @jdenny, it might be helpful if you were to take the existing dr5xx.cpp file and show us what you believe it would end up looking like with your approach.

https://gist.github.com/jdenny-ornl/82aae9c3706c88fedebc8c44ac2a6694


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150856/new/

https://reviews.llvm.org/D150856



More information about the llvm-commits mailing list