[PATCH] D149722: [AIX][TLS] Generate 64-bit local-exec access code sequence

Lei Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 16 08:56:17 PDT 2023


lei accepted this revision.
lei added a comment.

LGTM



================
Comment at: llvm/include/llvm/MC/MCExpr.h:302
     VK_PPC_AIX_TLSGDM,      // symbol at m
+    VK_PPC_AIX_TLSLE,       // symbol at le
     VK_PPC_GOT_TLSLD,       // symbol at got@tlsld
----------------
nemanjai wrote:
> lei wrote:
> > I realize this was done similar to `VK_PPC_AIX_TLS*`. but the symbol outputed seems to be too general and feels like we should fix this.  Shouldn't this be something more along the lines of `symbol at aix@tlsle`?
> These are actual strings printed in ASM (i.e. the textual representation of the relocation) so we can't freely add `aix` in there since the assembler would not know what to do with that.
I see.  Thank-you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149722/new/

https://reviews.llvm.org/D149722



More information about the llvm-commits mailing list