[llvm] df06594 - [llvm-gsymutil] Fix command descriptions introduced in upstream D148775 when switching to OptTable

Wanyi Ye via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 16 08:46:56 PDT 2023


Author: Wanyi Ye
Date: 2023-06-16T11:46:44-04:00
New Revision: df06594a8ccb8afec581442c1ea2508813e98210

URL: https://github.com/llvm/llvm-project/commit/df06594a8ccb8afec581442c1ea2508813e98210
DIFF: https://github.com/llvm/llvm-project/commit/df06594a8ccb8afec581442c1ea2508813e98210.diff

LOG: [llvm-gsymutil] Fix command descriptions introduced in upstream D148775 when switching to OptTable

[D148775](https://reviews.llvm.org/D148775) changed the help msg for `--addresses-from-stdin` option when switching to OptTable

This patch also fixed a small problem in the argument type error msg

Test Plan: NFC

Differential Revision: https://reviews.llvm.org/D153086

Added: 
    

Modified: 
    llvm/tools/llvm-gsymutil/Opts.td
    llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/tools/llvm-gsymutil/Opts.td b/llvm/tools/llvm-gsymutil/Opts.td
index 15e4688108175..740291479f932 100644
--- a/llvm/tools/llvm-gsymutil/Opts.td
+++ b/llvm/tools/llvm-gsymutil/Opts.td
@@ -34,4 +34,4 @@ def quiet : FF<"quiet", "Do not output warnings about the debug information">;
 defm address : Eq<"address", "Lookup an address in a GSYM file">;
 def addresses_from_stdin :
   FF<"addresses-from-stdin",
-     "Emit a section containing remark diagnostics metadata. By default, this is enabled for the following formats: yaml-strtab, bitstream">;
+     "Lookup addresses in a GSYM file that are read from stdin\nEach input line is expected to be of the following format: <addr> <gsym-path>">;

diff  --git a/llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp b/llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp
index 68d36f282dec0..307248ca34787 100644
--- a/llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp
+++ b/llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp
@@ -172,7 +172,7 @@ static void parseArgs(int argc, char **argv) {
   for (const llvm::opt::Arg *A : Args.filtered(OPT_address_EQ)) {
     StringRef S{A->getValue()};
     if (!llvm::to_integer(S, LookupAddresses.emplace_back(), 0)) {
-      llvm::errs() << ToolName << ": for the --segment-size option: '" << S
+      llvm::errs() << ToolName << ": for the --address option: '" << S
                    << "' value invalid for uint argument!\n";
       std::exit(1);
     }


        


More information about the llvm-commits mailing list