[PATCH] D152669: [AIX][TLS] Generate 32-bit local-exec access code sequence

Lei Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 16 08:25:49 PDT 2023


lei accepted this revision as: lei.
lei added a comment.
This revision is now accepted and ready to land.

Just a minor comment otherwise LGTM.
Thx



================
Comment at: llvm/lib/Target/PowerPC/PPCTLSDynamicCall.cpp:86-87
         Register GPR4 = Is64Bit ? PPC::X4 : PPC::R4;
         if (!IsPCREL)
-          InReg = MI.getOperand(1).getReg();
+          InReg = !IsTLSTPRelMI ? MI.getOperand(1).getReg() : InReg;
         DebugLoc DL = MI.getDebugLoc();
----------------
Since I believe the only time we want to override `InReg` is if both of those conditions are true?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152669/new/

https://reviews.llvm.org/D152669



More information about the llvm-commits mailing list